Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BillingName to be assigned in email receipts IF available #15688

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Moves the assignment of billingName to message templates to a place used by all receipts rather than relying on form to assign

Before

Not assigned for IPN type receipts - even if stored

After

Assigned

Technical Details

Previously it was assigned at the form layer, now we assign it in the email sending routine, depending on
whether the contribution has address_id & there is a value assigned

Comments

@seamuslee001 this will beat one of the blockers to getting 'contributeMode' out of the receipts

@civibot civibot bot added the master label Nov 1, 2019
@civibot
Copy link

civibot bot commented Nov 1, 2019

(Standard links)

@seamuslee001
Copy link
Contributor

Code looks right to be and i'm confident this has plenty of unit tests so if Jenkins is ok with this i am too merge on pass

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 I think I'd be OK with pulling the other check that is failing out of the test - based on the current params it legit shouldn't have the string 'Credit Card Information' & I feel like we've addressed this one 'properly' so could take a shortcut on that one

@seamuslee001
Copy link
Contributor

@eileenmcnaughton test fails relate

Previously it was assigned at the form layer, now we assign it in the email sending routine, depending on
whether the contribution has address_id & there is a value assigned
@eileenmcnaughton
Copy link
Contributor Author

Nothing like a good enotice

@eileenmcnaughton eileenmcnaughton merged commit 677e677 into civicrm:master Nov 1, 2019
@eileenmcnaughton eileenmcnaughton deleted the billing_name branch November 1, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants