Civi\Core\Container - Fix warning about Symfony 3=>4 and boot services #15704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boot services are initialized before the container starts -- and then passed in via `$container->set()`. Symfony 3.4 changes the default handling of `set()` - it now emits warnings unless the services were previously flagged as public. https://symfony.com/blog/new-in-symfony-3-4-services-are-private-by-default Before ------ ``` [bknix-min:~/bknix/build/d8re] drush php Psy Shell v0.9.9 (PHP 7.0.32 — cli) by Justin Hileman >>> \Drupal::service('civicrm')->initialize(); PHP Deprecated: The "runtime" service is private, replacing it is deprecated since Symfony 3.2 and will fail in 4.0. in /Users/totten/bknix/build/d8re/vendor/symfony/dependency-injection/Container.php on line 190 PHP Deprecated: The "paths" service is private, replacing it is deprecated since Symfony 3.2 and will fail in 4.0. in /Users/totten/bknix/build/d8re/vendor/symfony/dependency-injection/Container.php on line 190 PHP Deprecated: The "userSystem" service is private, replacing it is deprecated since Symfony 3.2 and will fail in 4.0. in /Users/totten/bknix/build/d8re/vendor/symfony/dependency-injection/Container.php on line 190 PHP Deprecated: The "userPermissionClass" service is private, replacing it is deprecated since Symfony 3.2 and will fail in 4.0. in /Users/totten/bknix/build/d8re/vendor/symfony/dependency-injection/Container.php on line 190 PHP Deprecated: The "cache.settings" service is private, replacing it is deprecated since Symfony 3.2 and will fail in 4.0. in /Users/totten/bknix/build/d8re/vendor/symfony/dependency-injection/Container.php on line 190 PHP Deprecated: The "settings_manager" service is private, replacing it is deprecated since Symfony 3.2 and will fail in 4.0. in /Users/totten/bknix/build/d8re/vendor/symfony/dependency-injection/Container.php on line 190 PHP Deprecated: The "lockManager" service is private, replacing it is deprecated since Symfony 3.2 and will fail in 4.0. in /Users/totten/bknix/build/d8re/vendor/symfony/dependency-injection/Container.php on line 190 ``` After ----- The warnings don't appear. Comments -------- The `Definition` class includes two methods, `setPublic()` and `setPrivate()`, which appear to do the same thing (but as opposites). `setPublic()` exists Symfony 2.8+, but `setPrivate()` was added in Symfony 3.x, so we use `setPublic()` for broader compatibility.
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
"Boot services" are initialized during bootstrap (before the container starts) -- and then passed into the container via
$container->set().Symfony 3.4 changes the default handling of
set()- it now emits warnings unless the services were previously flagged as public.https://symfony.com/blog/new-in-symfony-3-4-services-are-private-by-default
Before
After
The warnings don't appear.
Comments
The
Definitionclass includes two methods,setPublic()andsetPrivate(), which appear to do the same thing (but as opposites).setPublic()exists in Symfony 2.8+, butsetPrivate()was added in Symfony 3.x, so we usesetPublic()for broader compatibility.