Fix test to be more valid #15743
Merged
Fix test to be more valid #15743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added a check to run after tests & before tearDown to ensure that all payments have the right entity_financial_trxn records. This required fixing one ttest to be valid. It's not possible to create a contribution using the back office for with status set to Partially Paid (it's not an option in the drop down, so the test should create as Pending & then add a payment to get to partially paid
|
(Standard links)
|
|
Only affects tests so Jenkins is the real checker here and is ok with it merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I've added a check to run after tests & before tearDown to ensure that all payments have the
right entity_financial_trxn records.
This required fixing one test to be valid. It's not possible to create a contribution using the
back office for with status set to Partially Paid (it's not an option in the drop down, so
the test should create as Pending & then add a payment to get to partially paid
Before
Payment validity not checked in this class
After
Checked
Technical Details
I want to add this test to a bunch of classes that deal with payments - but there are some test setup issues to resolve
Comments