Provide precautionary handling for theoretical error scenario. #15748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
line_item_belt_braces
branch
2 times, most recently
from
d7a884f to
e5e642d
Compare
|
This will need rebasing if 15740 is merged first. I'll do that locally to test |
|
I've tested applying after #15740 This works fine. I'll add and do more testing, but this looks good. Obviously the failing test needs to be sorted. |
While testing payments I hit a bug where I tried to add a payment to a contribution with no financial items. I never managed to replicate it again or determine how the payment came to be in that state but it's been playing in my mind that people could get fatal errors if the financial_items don't exist and dealing with those as regression reports will very tough. So my plan is - for 5.20 add this extra routine to create it if it does not exist - use this mechanism + more digging to figure out how legit an issue it is civicrm#15706 - in future releases 'get noisy' about having to create them if they don't exist - eventually remove this routine
eileenmcnaughton
force-pushed
the
line_item_belt_braces
branch
from
e5e642d to
cc9f288
Compare
|
rebased - MOP added based on @kcristiano's input |
|
unrelated fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Provides protection against fatal errors when adding payments if financial_items have not been created. This may only be a theoretical risk but it buys us more time to ensure it is not a 'thing' without users hitting regressions if it is.
Before
Adding a payment to a contribution with no line item financial items results in a fatal.
It's unclear at this stage if there is any legitimate way to create a contribution with line items & no financial items for those lines but should that be the case it would be handled with this patch.
After
Missing item is created, no fatal.
Technical Details
While testing payments I hit a bug where I tried to add a payment to a contribution with no financial items.
I never managed to replicate it again or determine how the payment came to be in that state but
it's been playing in my mind that people could get fatal errors if the financial_items don't exist
and dealing with those as regression reports will very tough. So my plan is
Comments
@kcristiano this provides at least a band-aid for the non-replicable error I hit that has been playing on my mind