Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailing Report: hide the HTML preview #16899

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

mlutfy
Copy link
Member

@mlutfy mlutfy commented Mar 25, 2020

Overview

When viewing a mailing report, it displays a preview of the HTML. Only so much can be said in 30 characters of HTML, so it looks like this:

Capture d’écran de 2020-03-25 17-16-24

I'm pretty sure everyone here just got used to ignoring that "DOCTYPE html PUBLIC" string. I really don't see the purpose of it.

After

Removed the HTML preview, as well as the bold/strong:

Capture d’écran de 2020-03-25 17-17-09

@civibot
Copy link

civibot bot commented Mar 25, 2020

(Standard links)

@civibot civibot bot added the master label Mar 25, 2020
@jitendrapurohit
Copy link
Contributor

I've applied the PR and tested the display of preview on the report page. It does what it aims to remove the preview text from the report screen. The text seems unwanted and don't think it should be displayed.

From git blame, it looks like this was added long back from the initial stage. Either we need to update it to display only the truncated part of body/subject + link OR the current fix looks good which keeps the link to complete message in popup.

@yashodha
Copy link
Contributor

yashodha commented Apr 6, 2020

test this please

@yashodha
Copy link
Contributor

yashodha commented Apr 8, 2020

@mlutfy @jitendrapurohit looks good, can be merged. Thanks!

@yashodha yashodha merged commit e775e7d into civicrm:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants