Fix bug on handling 'is_required'

[eileenmcnaughton]

Overview

Fixes a bug that affects extensions using the generic form to render non-required select fields

Before

• Install https://github.com/eileenmcnaughton/uk.squiffle.assignee*
• load the settings page
• note that 'none' is not an option for the group field, even through it is defined correctly

** (this is a patched version of @aydun's extension with fixes to comply better with more recent code changes - I will submit a PR back to the copy @aydun maintains once it is in gitlab or github)

After

'none' loads as an option for the group field on the settings page

Technical Details

The code was expecting 'Select' but we encourage 'select' in the settings spec

However, we DO know the case to expect for the quickFormType - so check that instead

Comments

@mattwire maybe one you have good familiarity with

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[seamuslee001]

I'm a +1 on this but will let matt comment as well

[eileenmcnaughton]

test this please

[yashodha]

@eileenmcnaughton tests all pass, ready to merge?