dev/core#1685 - Search builder returns DB error on Group => Empty filter #16953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
approved these changes
Apr 6, 2020
|
I was able to replicate this and confirmed that this fixes the bug and also has a test to lock in the behaviour |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix DB error on Group => Empty filter via search builder.
Before
See steps to replicate on gitlab - https://lab.civicrm.org/dev/core/-/issues/1685
After
Fixes the error and displays the search result correctly.
Comments
relates to #14618. ping @eileenmcnaughton
Gitlab - https://lab.civicrm.org/dev/core/-/issues/1685
Unit test added.