Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/translation#4 - Add nl_BE language #16966

Merged
merged 1 commit into from
Apr 5, 2020

Conversation

demeritcowboy
Copy link
Contributor

Overview

This was never fully completed. The daily l10n tarball includes it now so this now adds it to the option group and installer screen.

Before

The language was there and is 86% translated due to sync from nl_NL, but wasn't actually available in CiviCRM.

After

Now available.

Technical Details

Comments

To be consistent with the other language variants I needed to change the existing "Dutch" option value to "Dutch (Netherlands)". This means that that string itself will now be untranslated in the languages dropdown. That may or may not be confusing for a bit until it gets retranslated but I didn't see a choice.

@mlutfy

@civibot civibot bot added the master label Apr 3, 2020
@civibot
Copy link

civibot bot commented Apr 3, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor

Seems a lot of related tests are failing on this but his isn' - hopefully merging fixes them.....

@eileenmcnaughton eileenmcnaughton merged commit e546963 into civicrm:master Apr 5, 2020
@demeritcowboy
Copy link
Contributor Author

We should document this r-Hail Mary pass in the review templates (he he).

@demeritcowboy demeritcowboy deleted the add-nlbe branch April 5, 2020 15:32
This was referenced Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants