[REF] Update custom data handing in contact import #16986
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Cleanup custom field handling in contact import.
Before
Over-reliance on
htlm_type
.After
Uses more standard
isSerialized
method.Comments
The other import classes got similar cleanup in #16979, which was merged by @Eileen. This one was a bit more cumbersome. I still consider the large amount of duplicated code across the 5 import classes to be a big FIXME, as it makes maintenance like this far more difficult than it should be.
The diff is not as large as it looks; changing the
switch
to if/else caused the indentation to change.