Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting custom field TextArea attributes #16997

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Apr 6, 2020

Overview

Fix code that was potentially overwriting attributes for existing fields during update ops.

Before

Attributes could be overwritten during update.

After

Defaults only set for create; preserved for update.

Comments

The comment made no sense whatsoever, but was friendly enough to end with a smiley :)

The code was potentially overwriting attributes for existing fields during update ops
@civibot
Copy link

civibot bot commented Apr 6, 2020

(Standard links)

@civibot civibot bot added the master label Apr 6, 2020
@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

OK - I took a look into this code and agree this makes sense - not sure about the fail - but good to merge if it passes this time

@seamuslee001 seamuslee001 merged commit 116a088 into civicrm:master Apr 6, 2020
@eileenmcnaughton eileenmcnaughton deleted the textAreaAttrs branch April 7, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants