Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] CustomField code cleanup to use isSerialized method #17009

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Apr 7, 2020

Overview

Part of a series of code refactors to reduce guesswork about custom field serialization.

Before

Relies on html_type to guess at serialization

After

Uses isSerialized

@civibot
Copy link

civibot bot commented Apr 7, 2020

(Standard links)

@civibot civibot bot added the master label Apr 7, 2020
@pradpnayak
Copy link
Contributor

Changes look good, will do some test soon.

@pradpnayak
Copy link
Contributor

Tested by creating and updating fields through UI and api. Data against record is saved and retrieved correctly against the entity.

Good to merge.

@colemanw colemanw merged commit 0ff7d95 into civicrm:master Apr 7, 2020
@colemanw colemanw deleted the multi-cleanup5 branch April 7, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants