[REF] Clarify variable & tighten use. #17016
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code tidy up in heavily tested dedupe code
Before
$customTableToCopyFrom is always an array - but the code handles the possibility it is null
After
$customTableToCopyFrom is strictly an array and possibility of null handling is removed
Technical Details
moveContactBelongings is only called from one place which passes in all the function variables, so we don't need defaults.
The last parameter, is retrieved from self::getAffectedCustomTables which always returns an
array - so all the handling for it being NULL can be removed....
Comments