set is_deceased to not null in schema and upgrade script dev/core#1697

[michaelmcandrew]

See https://lab.civicrm.org/dev/core/-/issues/1697

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Hey @michaelmcandrew - thanks for this, good to get the schema cleaned up.

Two FYIs:

1. Updating a schema xml file requires running /xml/GenCode.php to regenerate the corresponding DAO file.
2. Please avoid creating branches on github/civicrm and use your own fork to keep things tidy.

Cheers!

[colemanw]

I've done the regen and also squashed the commits. This is now good to go!

[michaelmcandrew]

1. Updating a schema xml file requires running /xml/GenCode.php to regenerate the corresponding DAO file.

Thanks - should have remembered to do that.

2. Please avoid creating branches on github/civicrm and use your own fork to keep things tidy.

Sorry - I keep on doing that - will try harder in future.

[colemanw]

No worries thanks for the PR @michaelmcandrew