Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/translation#4 - Upgrade script for nl_BE #17027

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

demeritcowboy
Copy link
Contributor

Overview

Adds missing upgrade step to add the option value for existing installs.

Before

E_NOTICE and can't select the language.

After

Good

Comments

Doesn't need backport if going with #17021

@civibot
Copy link

civibot bot commented Apr 8, 2020

(Standard links)

@civibot civibot bot added the master label Apr 8, 2020
@seamuslee001
Copy link
Contributor

Looks good to me merging

@seamuslee001 seamuslee001 merged commit ed5a763 into civicrm:master Apr 9, 2020
@demeritcowboy
Copy link
Contributor Author

Thanks. Just realized I missed an edge-case since the update for nl_NL doesn't limit to the option_group_id. Will put up a PR.

@totten
Copy link
Member

totten commented Apr 9, 2020

FWIW, I did an r-run of this locally. It worked as advertised in the current version, but I was concerned about future-proofing the upgrade steps - hence #17048.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants