Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Extend custom field test trait & some related tests #17037

Merged
merged 1 commit into from
Apr 10, 2020
Merged

[Test] Extend custom field test trait & some related tests #17037

merged 1 commit into from
Apr 10, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 9, 2020 •
edited
Loading

Overview

This extends the test custom data trait to have metadata for all html+data type combos for custom fields

Before

Less types defined

After

All defined - createFieldsOfAllTypes doesn't yet do all as it's a bit tedious

Technical Details

Comments

@colemanw

@civibot
Copy link

civibot bot commented Apr 9, 2020

(Standard links)

@civibot civibot bot added the master label Apr 9, 2020
@eileenmcnaughton eileenmcnaughton force-pushed the dupe branch 3 times, most recently from 3c68599 to 3662fe9 Compare April 10, 2020 02:15
@colemanw
Copy link
Member

Good to have more tests here.

@eileenmcnaughton eileenmcnaughton merged commit 88c3eb8 into civicrm:master Apr 10, 2020
@eileenmcnaughton eileenmcnaughton deleted the dupe branch April 10, 2020 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw