Convert bcc field to use an entity reference.

[eileenmcnaughton]

Overview

This changes the bcc field on all email fields to use an entity reference fields. This gives significant code simplification as well as extending filtering on the field

Note I've restricted to the bcc field for now as having it different makes it easier to do comparitive
testing. The other fields will follow once this is merged

Before

Custom js & php code for this use case - same as the cc field.

After

Entity reference box

Technical Details

@mfb - I did some testing on this & in my tests it performs well - it uses 2 queries not a union (if required ) but avoids the OR

@colemanw can you try this out? Note I've ONLY done the bcc field so far & as yet tags & groups don't filter

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

This is cool. I can't believe how crazy the old widget was - using "contact id + email string" as the "id" field. Using "email.id" is so much saner.

One nitpick: the "description" field includes a redundant copy of the sort name.

[eileenmcnaughton]

@colemanw I'm glad you picked up that nitpick - because I wasn't sure what was best there - I think originally I had display name & sort name (rather than both being sort) - but I'm not sure if it should just be sort

[eileenmcnaughton]

Looks like when I changed label_field to sort_name that created a duplication

civicrm-core/api/v3/Email.php

Line 94 in 30420aa

'contact_id.sort_name',

[colemanw]

I think just sort_name as the display value and email as the description is fine.

[eileenmcnaughton]

@colemanw I think you had some thought about how I could add groups & tags to the filter on email?

[eileenmcnaughton]

@colemanw I've updated the label & added some comments as well. The groups & tags thing is more of a follow up

[eileenmcnaughton]

@colemanw where do you think we are on this? I'd be happy to leave it as just the bcc field for this rc & encourage larger sites to do further testing (eg. @lucianov88 @mfb @pfigel ) before switching 'to' & 'cc' over.

Also I'd like to discuss extending to filtering on tags & groups

[colemanw]

This is working well, code looks good & passes tests. I'd be happy to merge a PR for the other email fields too, and we can test them all in this RC.