[REF] Stop passing ids to membership::create from createRelatedMemberships

[eileenmcnaughton]

Overview

Optional param $ids should not be passed to Membership::create when it has no meaning

Before

CRM_Member_BAO_Membership::create($params, $ids);

After

CRM_Member_BAO_Membership::create($params);

Technical Details

We are passing in an empty array. Per the code comments there was concern that the array might NOT be empty after calling
create & that needed to be checked out. However, I just went through it & concluded that values in the ids var would
only ever be set if ids['membership'] was passed in - so if it goes in empty it will come out empty

Comments

@mattwire we stopped short of doing this last time but I dug a bit further & can't see how $ids would be altered in the function if it starts off empty

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[yashodha]

@eileenmcnaughton looks good and seems to be in continuation of work in #17086