[REF] get rid of variable variable structure #17089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
memdate
branch
from
19e2733 to
66b8b8e
Compare
|
retest this please |
CRM/Member/BAO/Membership.php
Outdated
| @@ -269,15 +268,11 @@ public static function create(&$params, &$ids = []) { | |||
| $excludeIsAdmin = TRUE; | |||
| } | |||
|
|
|||
| $calcStatus = CRM_Member_BAO_MembershipStatus::getMembershipStatusByDate($start_date, $end_date, $join_date, | |||
| $calcStatus = CRM_Member_BAO_MembershipStatus::getMembershipStatusByDate($params['start_date'], $params['$end_date'], $params['join_date'], | |||
There was a problem hiding this comment.
@eileenmcnaughton there is a stray $ in the end_date
eileenmcnaughton
force-pushed
the
memdate
branch
from
66b8b8e to
a672cae
Compare
tests/phpunit/api/v3/ContactTest.php
Outdated
| $contactmembership = $this->callAPISuccess("membership", "getsingle", [ | ||
| "contact_id" => $contact["id"], | ||
| ]); | ||
| $contactmembership = $this->callAPISuccessGetSingle('membership', ['contact_id' => $contact["id"],]); |
There was a problem hiding this comment.
minor thing but why the trailing ,? @eileenmcnaughton
There was a problem hiding this comment.
Jenkins didn't think it was minor
eileenmcnaughton
force-pushed
the
memdate
branch
from
a672cae to
070a89a
Compare
Readability improvement
eileenmcnaughton
force-pushed
the
memdate
branch
from
070a89a to
e6d0c73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Readability improvement
Before
After
Technical Details
Variable variables are hard to read
Comments