(REF) CRM_Utils_Hook - Remove deprecated formulations of invoke(int,…)
#17124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…...)` Overview -------- The signature of `CRM_Utils_Hook::invoke()` originally took an argument `int $count` (number of hook args), but circa 4.7 it changed to prefer `string[] $names` (symbolic names for each hook arg). The `int` notation doesn't provide enough information to fire via Symfony EventDispatcher and was mostly replaced/deprecated, but `int` notation is still supported for backward compatibility. This cleans a couple oddballs using the `int` notation. Before ------ Some stub functions in `CRM_Utils_Hook` still use the `invoke(int,...)` formulation: * `hook_themes` fell through a crack because it had a long PR (years?) that overlapped with the change in `invoke()`. * `hook_install` (etc) looks like `int`, but it's not actually used. After ----- None of the stub functions in `CRM_Utils_Hook::invoke(string[], ...)` use `int` formulation.
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The signature of
CRM_Utils_Hook::invoke()originally took an argumentint $count(number of hook args), but circa 4.7 it changed to preferstring[] $names(symbolic names for each hook arg). Theintnotation doesn't provide enough information to fire via Symfony EventDispatcher and was mostly replaced/deprecated, butintnotation is still supported for backward compatibility.This cleans a couple oddballs using the
intnotation.Before
Some stub functions in
CRM_Utils_Hookstill useintformulation.hook_themesfell through a crack because it had a long PR (years?) that overlapped with the change ininvoke().hook_install(etc) looks likeint, but it's not actually used.After
None of the stub functions in
CRM_Utils_Hookuseintformulation.