Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] [Test] minor code cleanup #17152

Merged
merged 1 commit into from
Apr 23, 2020
Merged

[NFC] [Test] minor code cleanup #17152

merged 1 commit into from
Apr 23, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Cleanup within a test class

Before

More duplication, less compliance with best practices

After

Reversed

Technical Details

More duplication remains...

Comments

@civibot
Copy link

civibot bot commented Apr 23, 2020

(Standard links)

@civibot civibot bot added the master label Apr 23, 2020
@eileenmcnaughton eileenmcnaughton merged commit 5fa8d81 into civicrm:master Apr 23, 2020
@eileenmcnaughton eileenmcnaughton deleted the act2 branch April 23, 2020 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw