Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Superficial code clean up #17155

Merged
merged 1 commit into from
Apr 23, 2020
Merged

[NFC] Superficial code clean up #17155

merged 1 commit into from
Apr 23, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Cleanup on comment blocks, use of double quotes, failure to do strict comparison, formatting

Before

array()
"blah"
$blah == 'pdf'

After

[]
'blah'
$blah === 'pdf'

Technical Details

Comments

@civibot
Copy link

civibot bot commented Apr 23, 2020

(Standard links)

@civibot civibot bot added the master label Apr 23, 2020
@seamuslee001
Copy link
Contributor

@eileenmcnaughton the style police has logged on https://test.civicrm.org/job/CiviCRM-Core-PR/33591/checkstyleResult/new/

@eileenmcnaughton eileenmcnaughton force-pushed the pdf branch 2 times, most recently from b2ac3c9 to 9794634 Compare April 23, 2020 10:45
@yashodha
Copy link
Contributor

@eileenmcnaughton looks good, merging this

@yashodha yashodha merged commit ad909a0 into civicrm:master Apr 23, 2020
@eileenmcnaughton eileenmcnaughton deleted the pdf branch April 23, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eileenmcnaughton @seamuslee001 @yashodha @colemanw