[REF] APIv4 - Enforce contact field permissions via metadata #17168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss override Now that 'permission' metadata has been added to the schema, there's no need for specialized code for that field. This adds generic code to handle any field with permissions declared.
|
(Standard links)
|
|
retest this please |
|
@colemanw is this specifically tested? If so I think it's good to merge |
|
@eileenmcnaughton yes there's several tests for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactors the way field permissions are enforced.
Now that 'permission' metadata has been added to the schema, there's no need for specialized code for that field.
This adds generic code to handle any field with permissions declared.
Before
Special handling.
After
Generic handling. Same result.