Further removal of long-deprecated skipCleanMoney #17175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per civicrm@243320e NOT setting this true (ie having the function clean up the money has been giving deprecation notices for a year, it can go now
|
(Standard links)
|
|
Changes look good to me merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Per 243320e - remove legacy deprecated handling for skipCleanMoney
Before
Calling checkTaxAmount will only clean money if
$ugWeDoNotKnowIfItNeedsCleaning_Helpis TRUE - doing so will give a deprecation warning & 'clean' the moneyAfter
money is expected to be clean.
Technical Details
NOT setting this true (ie having the function clean up the money has been giving deprecation notices
for a year, it can go now
Comments
Note the 2 places where this param WAS true are db-loaded browse displays, not user input so should be fine