Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] [Test] IDE cleanup on ReportTemplateTest #17197

Merged
merged 1 commit into from
May 5, 2020
Merged

[REF] [Test] IDE cleanup on ReportTemplateTest #17197

merged 1 commit into from
May 5, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Code cleanup in test class

Before

Margin super-colourful in IDE

After

Easier to spot ACTUAL errors, code more compliant

Technical Details

Various - comments, use of double quotes, less preferred or deprecated functions.

Comments

@civibot
Copy link

civibot bot commented Apr 30, 2020

(Standard links)

@civibot civibot bot added the master label Apr 30, 2020
@eileenmcnaughton
Copy link
Contributor Author

test this please

1 similar comment
@eileenmcnaughton
Copy link
Contributor Author

test this please

@colemanw
Copy link
Member

colemanw commented May 1, 2020

@eileenmcnaughton can you pls rebase this?

@eileenmcnaughton
Copy link
Contributor Author

rebased!

@eileenmcnaughton
Copy link
Contributor Author

test this please

@seamuslee001
Copy link
Contributor

Changes look good to me merging

@seamuslee001 seamuslee001 merged commit 623f632 into civicrm:master May 5, 2020
@seamuslee001 seamuslee001 deleted the act_r_test branch May 5, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @colemanw @seamuslee001