Convert fatals to statusBounces in case forms #17212
Conversation
|
(Standard links)
|
| } | ||
| if (count($form->_caseId) != 1) { | ||
| CRM_Core_Resources::fatal(ts('Expected one case-type')); |
There was a problem hiding this comment.
This sounds familiar. It comes from here as copy/paste - eb20fbf, but sort of makes sense. The actual issue is that _caseId became an array, so it was part of a larger change to only use the first one, and then a sanity check that there is only one when having more than one made no sense. But the wording is wrong since it has nothing to do with case types.
There was a problem hiding this comment.
Also they got the class wrong. CRM_Core_Resources::fatal() doesn't exist!
CRM/Case/Form/ActivityToCase.php
Outdated
| */ | ||
| public function preProcess() { | ||
| $this->_activityId = CRM_Utils_Request::retrieve('activityId', 'Positive'); | ||
| if (!$this->_activityId) { | ||
| CRM_Core_Error::fatal('required activity id is missing.'); | ||
| CRM_Core_Error::statusBounce('required activity id is missing.'); |
There was a problem hiding this comment.
They all seem ok I'm just not sure about this one. This form is a form but not a form - as far as I know it's only reached via an ajax snippet, and when I try to force a failure it gives me a weird screen with the error squished inside an unnecessarily small textbox. But I get the same thing before the patch so that's ... good?
There was a problem hiding this comment.
@demeritcowboy I've switched it to throw an Exception since there is no clear case for a statusBounce and throwing an exception is closer to no change
|
test this please |
1 similar comment
|
test this please |
|
@demeritcowboy is this good to merge? |
|
Yes! |
Overview
Replaces calls to fatal with statusBounce where they are in the case forms
Before
CRM_Core_Error::fatal
After
CRM_Core_Error::statusBounce
Technical Details
In general users should experience the bounce message whereas code should catch exceptions. So in the form layer it's
CRM_Core_Error::statusBounceand in the BAOthrow new CRM_Core_ExceptionandCRM_Core_Error::fatalis oh-so-2014I'm just assuming form layer due to the folder these are in
Comments
@demeritcowboy