[REF] Permit domain tokens being used within Thank You letters #17230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
monishdeb
approved these changes
May 5, 2020
mattwire
requested changes
May 5, 2020
There was a problem hiding this comment.
@seamuslee001 Just one request to move a line of code and then this is good to merge.
Comment on lines
231
to
232
| $domain = CRM_Core_BAO_Domain::getDomain(); | ||
| $tokenHtml = CRM_Utils_Token::replaceDomainTokens($tokenHtml, $domain, TRUE, $messageToken); |
There was a problem hiding this comment.
@seamuslee001 Can you put this above replaceContactTokens() - we found a scenario with the mailings recently when for some reason replaceContactTokens() stripped the domain tokens and they didn't get set.
Re-arrange code as per Matt's comment
seamuslee001
force-pushed
the
domain_token_thank_you_letter
branch
from
ce6123b to
cb9b864
Compare
|
@mattwire done now |
|
Merging as per MOP tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Contribution Thank you letters do not output domain tokens e.g. {domain.name}
Before
Domain tokens are not outputted in Contribution Thank you letters
After
Domain tokens are replaced in Contribution Thank You letters
ping @mattwire @eileenmcnaughton @monishdeb