Reporting #20 - correct stats when force=1 on Contribution Detail Report

[MegaphoneJon]

https://lab.civicrm.org/dev/report/issues/20

Overview

When a contribution has multiple soft credits, this causes the Contribution Detail Report to be incorrect. My previous fix, #15315, fixed the problem for the rows but not the statistics. This fixes it for both.

Steps to replicate:

• Create a contribution with two soft credits.
• Run the contribution detail report with force=1: http://dmaster.localhost/civicrm/report/contribute/detail?force=1
• Note the (incorrect) total amount.
• Without changing anything, press "Refresh Results".
• Note that even though no settings have changed, the total amount is now lower (and correct).

Before

Incorrect statistics.

After

Statistics are correct.

Technical Details

The heart of the issue is that most filters, when untouched, are blank/null. However, "Contributions or Soft Credits" can never be null, because there's no null value. However, that's only true when the form is loaded; when the form isn't loaded (i.e. with force=1), the value is NULL. That causes force=1 to return different results. By setting the default explicitly, this is avoided. I also revert my old fix, which treats a NULL as contributions_only, since this only fixes rows and not statistics.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

(CiviCRM Review Template WORD-1.2)

• General standards
  • (r-explain) Pass
  • (r-user) Pass
  • (r-doc) Pass
  • (r-run) Pass Confirm that this fixes the problem identified and that the statistics are now correct
• Developer standards
  • (r-tech) Pass
  • (r-code) Pass
  • (r-maint) Pass
  • (r-test) Pass