(REF) dev/core#1744 - Cleanup event naming

[totten]

Overview

This is a cleanup in that it consolidates the code-style by which certain events are organized.

Discussion/rationale: https://lab.civicrm.org/dev/core/-/issues/1744

Before

For any given event, there are up to 3 distinct names -- the class-name (eg TokenRegisterEvent), the event-name (eg civi.token.list), and the constant-name (eg TOKEN_REGISTER).

The usage of event-name vs constant-name is inconsistent. You find numerous examples of both these formulations in civicrm-core

// Reference an event directly by its literal name
Civi::dispatcher()->addListener('civi.token.list', $callback);
Civi::dispatcher()->dispatch('civi.token.list', $event);

// Reference an event indirectly by a constant
Civi::dispatcher()->addListener(Civi\Token\Events::TOKEN_REGISTER, $callback);
Civi::dispatcher()->dispatch(Civi\Token\Events::TOKEN_REGISTER, $event);

After

The constants are mostly removed/deprecated. This string-literal formulation is canonical:

Civi::dispatcher()->addListener('civi.token.list', $callback);
Civi::dispatcher()->dispatch('civi.token.list', $event);

Technical Details

Normalizing/consolidating this involved a few changes:

• (REF) Search/replace - Simply substitute the constant with its value
• (NFC) Mark the old constant as @deprecated, but retain it for any third-party code or any unrecognized edge-cases.
• (NFC) Consolidate docblocks - Each event had a constant (TOKEN_REGISTER) and a class (TokenRegisterEvent). Docblocks describing the event could be on either. Any docblocks on the constant have been moved into the corresponding class.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

test fail unrelated