SyntaxConformanceTest::testSqlOperators - Fix failure on MySQL 8 #17262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before ------ `SyntaxConformanceTest::testSqlOperators` frequently fails on the `Dedupe` entity when running on MySQL 8 (`bknix-edge`). After ------ `SyntaxConformanceTest::testSqlOperators` repeatedly passes for all entities on my copy of MySQL 8 (`bknix-edge`). Technical Details ----------------- The `testSqlOperators` creates a small pool of example records (`$entities`), then it slices/dices that pool with a few SQL operators and asserts the number of matches. In particular: ```php $this->callAPISuccessGetCount($entityName, ['id' => ['>' => $entities[0]]], $totalEntities - 1); ``` The problem is that `$entities[0]` does not necessarily have the lowest ID -- because `$entities` was not fetched in any particular order. The default ordering is *often* the same as the `id`, but not always. I suspect that this problem manifests most frequently with the `Dedupe` entity because the underlying table (`civicrm_prevnext_cache`) is highly volatile (many writes+deletes) -- thus it's more likely to reuse old storage slots for new rows.
|
(Standard links)
|
|
Change makes sense and passed on a small test run on edge matrix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
SyntaxConformanceTest::testSqlOperatorsfrequently fails on theDedupeentity when running on MySQL 8 (bknix-edge).After
SyntaxConformanceTest::testSqlOperatorsrepeatedly passes for all entities on my copy of MySQL 8 (bknix-edge).Technical Details
The
testSqlOperatorscreates a small pool of example records ($entities), then it slices/dices that pool with a few SQL operators and asserts the number of matches.In particular:
The problem is that
$entities[0]does not necessarily have the lowest ID -- because$entitieswas not fetched in any particular order. The default ordering is often the same as theid, but not always.I suspect that this problem manifests most frequently with the
Dedupeentity because the underlying table (civicrm_prevnext_cache) is highly volatile (many writes+deletes) -- thus it's more likely to reuse old storage slots for new rows.IMHO, the problem ought to occur in many SQL environments, but the frequency of occurrence seems to vary by version.