Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#1867 CiviReport filters: Fix incorrect defaulting to the beginning rather than end the to-range day #17811

Merged
merged 1 commit into from
Jul 13, 2020
Merged

dev/core#1867 CiviReport filters: Fix incorrect defaulting to the beginning rather than end the to-range day #17811

merged 1 commit into from
Jul 13, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 13, 2020 •
edited
Loading

Overview

Per https://lab.civicrm.org/dev/core/-/issues/1867 the to date is being treated as having time 00:00:00 - @KarinG did some checks for us and confirmed this was not the case inn 5.21 and I believe it regressed inn 5.25
6d6630c#diff-d355cdb00cea3915a3cf306c6c08f6a6L2206

Before

Screen Shot 2020-07-13 at 5 51 49 PM

interpreted as from 1 July 2020 at 0 am to 13 July 2020 at 0 am

After

interpreted as from 1 July 2020 at 0 am to 13 July 2020 at 23:59:59 pm

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jul 13, 2020

(Standard links)

@civibot civibot bot added the 5.28 label Jul 13, 2020
@eileenmcnaughton eileenmcnaughton changed the title Fix incorrect defaulting to the beginning rather than end the to-rang… Fix incorrect defaulting to the beginning rather than end the to-range day Jul 13, 2020
@eileenmcnaughton eileenmcnaughton changed the title Fix incorrect defaulting to the beginning rather than end the to-range day CiviReport filters: Fix incorrect defaulting to the beginning rather than end the to-range day Jul 13, 2020
@eileenmcnaughton eileenmcnaughton changed the title CiviReport filters: Fix incorrect defaulting to the beginning rather than end the to-range day dev/core#1867 CiviReport filters: Fix incorrect defaulting to the beginning rather than end the to-range day Jul 13, 2020
@eileenmcnaughton eileenmcnaughton mentioned this pull request Jul 13, 2020
Merged
@seamuslee001
Copy link
Contributor

Tested this and confirmed working

@seamuslee001 seamuslee001 merged commit c287bfb into civicrm:5.28 Jul 13, 2020
@seamuslee001 seamuslee001 deleted the fromto branch July 13, 2020 22:20
@seamuslee001 seamuslee001 mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.28
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001