dev/core#1911 - Default not being set for fixed contribution amounts or any price field that is not type text

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/1911

The default setting for price field options no longer works as of 5.27.

Easiest way to see is:

1. On a stock demo site go to the amounts tab for the "Help Support CiviCRM" contribution page.
2. Observe that "Booster $10" is the default amount.
3. Just click save.
4. Go back to the amounts tab. Nothing is set as default.
5. Also if you visit the live page no default is selected.

You can also see it if you:

1. Create a price set.
2. Add a price field that is not type text, like type select.
3. Create a few options and set one as a default.
4. Go back and look at it and it's not the default.

Before

Can't have a default option for a price field.

After

Can

Technical Details

This commit rearranged the order.

Before, what it would do is clear out any other is_default, and THEN save the BAO which would set the new is_default.

After, it does the save before that clearout, so is_default gets set but then wiped out.

Comments

Has test.

There's also something else going on where the Review Your Contribution button does nothing when you click it if you don't have a default. That seems separate and seems to have changed in 5.28 not 5.27.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

(CiviCRM Review Template WORD-1.2)

• General standards
  • (r-explain) Pass
  • (r-user) Pass
  • (r-doc) Pass
  • (r-run) Pass I was able to replicate this issue locally and confirmed that this fixed the problem
• Developer standards
  • (r-tech) Pass
  • (r-code) Pass
  • (r-maint) Pass
  • (r-test) Undecided - Has a test tho MOP