dev/core#2187 Allow sites to customise the default number of rows ret… #18969
Conversation
|
(Standard links)
|
|
Related Gitlab, https://lab.civicrm.org/dev/core/-/issues/2187 |
|
So we have
This is only for the first from the looks - unless we intend to use it on the others we should make the setting more specific (e.g append quick_form) |
|
I would be happy to extend it further but figure start at Quickform, |
|
Yeah - I don't know if it makes sense to - ie current default for reports is 50 & for searchkit 10? I'll see what @colemanw thinks |
|
This seems to have stalled since November and it's not clear if there's agreement about the concept. Is there still interest in this? |
|
I think this is a good enhancement. |
|
I think it would be fine for SK to use this new setting. |
settings/Search.setting.php
Outdated
| 'is_domain' => 1, | ||
| 'is_contact' => 0, | ||
| 'description' => ts('What is the default number of records to show on a search'), | ||
| 'help_text' => ts('Set this to show a specific number of records'), |
There was a problem hiding this comment.
There's an open ticket about this somewhere that help_text doesn't work in the "new" settings system and it causes an error: User warning: Smarty error: unable to read resource: "CRM\Admin\Form\Setting\Search.hlp" in Smarty->trigger_error() (line 1108 of ...\packages\Smarty\Smarty.class.php). Until that's fixed you'll need to either leave out the help_text here or put some smarty in the tpl. The description here seems adequate so I think can leave it out.
settings/Search.setting.php
Outdated
| 'maxlength' => 3, | ||
| ], | ||
| 'default' => 50, | ||
| 'add' => '5.33', |
There was a problem hiding this comment.
It's no longer 5.33.
seamuslee001
force-pushed
the
dev_core_2187
branch
from
0a2c919 to
d14c972
Compare
…urned from QuickForm Searches
seamuslee001
force-pushed
the
dev_core_2187
branch
from
d14c972 to
7fa7c08
Compare
|
Ok I think we're good to go here. |
…urned from QuickForm Searches
Overview
This allows sites to customise the default number of rows returned by a QuickForm search rather than it being hard coded to 50 and users having to manipulate the counter at the bottom on each search.
Before
Default number hard coded as a constant 50 in
CRM_Utils_PagerAfter
Site configurable setting for number of search results returned defaults to 50 which was the original constant value.
Technical Details
I left the constant in CRM_Utils_Pager in case extensions had copied across code from core that used it but separated it out from the others to show it was deprecated.
ping @mattwire @eileenmcnaughton @MikeyMJCO @JoeMurray
You folks might be interested in this