Quick fix on summary actions conflict

[eileenmcnaughton]

Overview

Per eileenmcnaughton/org.wikimedia.contacteditor#8 &
mattwire/uk.co.mjwconsult.checksum#1

menu items are indexed by weight, resulting in a conflict between 2 items with the same weight -
this is just a quick & dirty fix to ensure we don't overwrite one menu item with another

Before

If 2 extensions add menu links with the same weight only the second one processed is displayed as the values are keyed by weight & the first is overwritten by the second

After

The weight is bumped up if already in use, avoiding some being lost

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

@eileenmcnaughton what about changing the if to while? That way it will keep incrementing until it gets a unique value.

[eileenmcnaughton]

@colemanw done - also fixed enotices hurting tests

[eileenmcnaughton]

@colemanw this should be mergeable