Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Sendconfirmation api to override pay later receipt text #19129

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

jitendrapurohit
Copy link
Contributor

Overview

An extension of fix done in #18789 to allow pay later receipt text in sendconfirmation api.

Before

Pay Later text from the contribution page is used even if it is overridden in the api call. Eg

civicrm_api3('Contribution', 'sendconfirmation', [
  'id' => contribution_id,
  'receipt_from_email' => "[email protected]",
  'pay_later_receipt' => 'Mail your check to [email protected] within 3 business days.',
]);

uses the pay later text set in the contribution page of the contribution. If contribution is not attached to any page, there is no way to send a pay later text in the receipt using sendconfirmation api.

After

Pay Later text included.

Comments

Added unit test.

@civibot
Copy link

civibot bot commented Dec 5, 2020

(Standard links)

@KarinG
Copy link
Contributor

KarinG commented Dec 5, 2020

@mattwire - this is part of our efforts to make Webform CiviCRM module independent of native Contribution Pages.

@mattwire
Copy link
Contributor

mattwire commented Dec 5, 2020

This is consistent with previous changes and has a test

@mattwire mattwire merged commit 30d51f5 into civicrm:master Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants