Clean up error handling in legacy functions in import parser #19160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| return civicrm_api3_create_error('Invalid value for custom field \'' . | ||
| CRM_Utils_Array::value('name', $custom) . '\'' | ||
| throw new CRM_Core_Exception('Invalid value for custom field \'' . | ||
| $custom['name'] . '\'' |
There was a problem hiding this comment.
So in theory it could have returned NULL here right?
There was a problem hiding this comment.
@seamuslee001 yeah - there is some risk this would give an e-notice but it seems like our metadata is more consistent now so less of this belt & braces handling is better
|
Looks fine to me lets see what the tests say |
|
test fails look to relate |
eileenmcnaughton
force-pushed
the
import
branch
from
61d1634 to
3fe5ba0
Compare
|
@eileenmcnaughton test fails still occurring |
|
@seamuslee001 yeah - I think I have to take a step back on this & clean up some of the weird duplicate stuff first - the first step (the weird if-else stuff) is merged now so will look again |
eileenmcnaughton
force-pushed
the
import
branch
2 times, most recently
from
b3fcc8e to
f93665e
Compare
|
Jenkins re test this please |
This makes the handling of errors cleaner & makes it easier for us to unravel what is going on here.
eileenmcnaughton
force-pushed
the
import
branch
from
f93665e to
eba173d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Clean up error handling in legacy functions in import parser
Before
Complicated error handling and code hard to move around because of the return statements
After
straight forward exception handling approach
Technical Details
This makes the handling of errors cleaner & makes it easier for us to unravel what is going on here.
Comments
@seamuslee001 this is another minor clean up step. I think it's going to make sense to copy the formatProfileContact into the import now that most of the first move is tidied up & then we can switch to calling the api - which will handle your bug