Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename internal references to contributionTypeId #19169

Merged
merged 1 commit into from
Dec 11, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Rename internal references to contributionTypeId
eileenmcnaughton committed Dec 10, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit abb88c2253b804fed16998f22f4bb4aa1b77a207
8 changes: 4 additions & 4 deletions CRM/Contribute/BAO/ContributionPage.php
Original file line number Diff line number Diff line change
@@ -363,13 +363,13 @@ public static function sendMail($contactID, $values, $isTest = FALSE, $returnMes
'contributionStatus' => $values['contribution_status'] ?? NULL,
];

if ($contributionTypeId = CRM_Utils_Array::value('financial_type_id', $values)) {
$tplParams['financialTypeId'] = $contributionTypeId;
if (!empty($values['financial_type_id'])) {
$tplParams['financialTypeId'] = $values['financial_type_id'];
$tplParams['financialTypeName'] = CRM_Core_DAO::getFieldValue('CRM_Financial_DAO_FinancialType',
$contributionTypeId);
$values['financial_type_id']);
// Legacy support
$tplParams['contributionTypeName'] = $tplParams['financialTypeName'];
$tplParams['contributionTypeId'] = $contributionTypeId;
$tplParams['contributionTypeId'] = $values['financial_type_id'];
}

if ($contributionPageId = CRM_Utils_Array::value('id', $values)) {