dev/financial#163 Removal of contributionTypeID #19174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| $value['contributionTypeID'] = $contribution->financial_type_id; | ||
| $value['receive_date'] = $contribution->receive_date; | ||
| $value['trxn_id'] = $contribution->trxn_id; | ||
| $value['contributionID'] = $contribution->id; | ||
| $value['contributionTypeID'] = $contribution->financial_type_id; |
There was a problem hiding this comment.
yeah we only need one of this & line 568
|
I'm not going to worry about the test fails unless this seems hard to get agreement on - if agreed I'll change to remove, otherwise we should get this passing & committed for next round of this |
|
Jenkins re test this please |
|
@eileenmcnaughton Yes definitely remove |
eileenmcnaughton
force-pushed
the
conttype
branch
from
7d59743 to
d1c11f5
Compare
eileenmcnaughton
force-pushed
the
conttype
branch
from
d1c11f5 to
c2978fe
Compare
|
Jenkins re test this please |
eileenmcnaughton
changed the title
|
This is now updated to remove rather than comment the relevant places |
|
@colemanw this should be good to merge now |
|
First we take contributionTypeID then we take contributionMode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
PR illustrates the remaining places where I propose to remove contributionTypeID. I will include this proposal in the dev-digest so this visualises is
Before
Hard to see what would be affected
After
PR makes the places clear
Technical Details
Depending on feedback this PR might be updated to actually remove the commented lines
Comments