#REF Migrate the print_array smarty plugin from in packages into core… #19206
Conversation
|
(Standard links)
|
| * Type: modifier<br> | ||
| * Name: print_array<br> | ||
| * Purpose: formats variable contents for display in the console | ||
| * @link http://smarty.php.net/manual/en/language.modifier.debug.print.var.php |
There was a problem hiding this comment.
From this (now invalid) link it looks like maybe it used to ship with core
There was a problem hiding this comment.
I think it was actually a copy of the debug print var modifier
There was a problem hiding this comment.
Looks like it was added here civicrm/civicrm-svn@a0b4995#diff-bab133e19b14acb008e3e5323e6078e7feee8998347d0de28ae3fdec1d3a7265R1 as part of https://issues.civicrm.org/jira/browse/CRM-8236
There was a problem hiding this comment.
@seamuslee001 OK - I see it used here
I'm OK with merging this but I want a bit more work on the comments so when people say 'can this be removed now' the comment block will make it clear they just need to grep '|@print_array}'
There was a problem hiding this comment.
@eileenmcnaughton thanks for that feedback, I have updated the comments now and also swapped out to use the CiviCRM copywrite as I cannot see it was ever part of the actual Smarty Package
…as it seems to not be supplied by the upstream package
seamuslee001
force-pushed
the
migrate_print_array
branch
from
5fb1a6f to
2bb3609
Compare
|
It's a bit more succinct than I would have been - but it does the trick |
… as it seems to not be supplied by the upstream package
Overview
This migrates the print_array modifier that is used by DAO processing and I think the Examples processing into civicrm_core from civicrm_packages as it seems it isn't provided by the upstream plugin as per https://github.com/smarty-php/smarty/tree/Smarty2/libs/plugins
Before
Modifier in packages
After
Modifier in core
ping @eileenmcnaughton