Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some more variable variables + some test cleanup #19208

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Remove some more variable variables + some test cleanup #19208

merged 2 commits into from
Dec 14, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Dec 14, 2020 •
edited
Loading

Overview

Remove some more variable variables

Before

$$dv  = NULL

After

$endDate = NULL

Technical Details

Ug

Comments

Ug

@civibot
Copy link

civibot bot commented Dec 14, 2020

(Standard links)

@civibot civibot bot added the master label Dec 14, 2020
@eileenmcnaughton eileenmcnaughton changed the title Deprecation - expect test fail - lessee Remove some more variable variables Dec 14, 2020
@eileenmcnaughton eileenmcnaughton changed the title Remove some more variable variables Remove some more variable variables + some test cleanup Dec 14, 2020
seamuslee001
seamuslee001 reviewed Dec 14, 2020
View reviewed changes
CRM/Member/Form/Membership.php
}
$endDate = $startDate = NULL;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why no $joinDate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the ide suggested it wasn't used

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@seamuslee001
Copy link
Contributor

Looks good to me merging

@seamuslee001 seamuslee001 merged commit fed38b1 into civicrm:master Dec 14, 2020
@seamuslee001 seamuslee001 deleted the mem_deb branch December 14, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seamuslee001 seamuslee001 seamuslee001 left review comments

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001