Remove or hard-code variables from previously shared function

[eileenmcnaughton]

Overview

Remove or hard-code variables from previously shared function

Before

processFormContribution(
    $params,
    $result,
    $contributionParams,
    $financialType,
    $online,
    $billingLocationID,
    $isRecur
  
  ) {

After

processFormContribution(
    $params,
    $result,
    $contributionParams,
    $financialType
  
  ) {

Technical Details

This function was separated from the shared function for cleanup.

This removes 3 variables

• isRecur (always true)
• billingId - this is elsewhere handled on the form
• online (always false)

For billing id this is handled through back office form
shared functions. The handling might be slightly different but it seems
more important that the form is internally consistent with how
it creates billing addresses (between recur & non-recur) than with other forms

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@seamuslee001 is this one you can merge - it's more clean up of the now-not-shared function

[seamuslee001]

This looks fine merging