Only do cms account create from the one relevant place

[eileenmcnaughton]

This function is called from 3 places - create CMS user is not applicable
to the back office form and the other place actually blocks it...

Overview

Move call to CRM_Contribute_BAO_Contribution_Utils::createCMSUser out of the shared function back to the one (out of 3 ) functions that call processFormContribution such that the CMSUser could be created

Before

The function is called from the back office contribution form (from which creating a CMS user is not relevant) and from 2 places in the confirm form - one of these specifically sets a parameter to stop it from being set - leaving just one place it can be set from - yet the call is in the shared function

After

call moved back to the function that actually requires it

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

This looks good to me