REF use addRadio function to add in the radio fields to these forms #19265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
force-pushed
the
use_add_radio
branch
from
08e96fe to
0077939
Compare
| $exportOptions[self::EXPORT_MERGE_SAME_ADDRESS] = ts('Merge All Contacts with the Same Address'); | ||
| $exportOptions[self::EXPORT_MERGE_HOUSEHOLD] = ts('Merge Household Members into their Households'); | ||
| foreach (array_keys($exportOptions) as $key) { | ||
| $exportOptionsJS[$key] = ['onClick' => 'showMappingOption( );']; |
There was a problem hiding this comment.
Some of these should be showGreetingOptions() right? Also I get Error: Call to a member function getName() on string in HTML_QuickForm_group->onQuickFormEvent()
There was a problem hiding this comment.
ah good point thanks for that pick up
|
This is good to merge once @demeritcowboy is happy with it |
Fixes following review by Dave D
seamuslee001
force-pushed
the
use_add_radio
branch
from
0077939 to
2428bd1
Compare
|
@demeritcowboy thanks for that pickup should be sorted now mate |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This refactors these 2 forms to use the addRadio function in CRM_Core_Form rather than manually creating radio elements then adding them to a group
Before
Using non centralised code
After
Using a centralised function
ping @demeritcowboy @eileenmcnaughton