[REF] Fix tax_amount to be consistent & load from the templateContribution #19274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ution This leverages the work done in https://github.com/civicrm/civicrm-core/pull/15517/files (the test in particular) but alters it to be more consistent. The original fix relied on the tax_amount on the contribution object passed in - this fixes it to get the amount from the templateContribution (which is more consistent now than when the patch was likely written
|
(Standard links)
|
eileenmcnaughton
changed the title
|
I suspect we might need to revisit |
|
@mattwire yeah - I suspect that an override amount (only available for 1 line item contributions) would work incorrectly before and after this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Fix tax_amount to be consistent & load from the templateContribution
This leverages the work done in https://github.com/civicrm/civicrm-core/pull/15517/files (the test in particular)
but alters it to be more consistent. The original fix relied on the tax_amount on the contribution object
passed in - this fixes it to get the amount from the templateContribution (which is more consistent
now than when the patch was likely written
Before
tax_amount taken from the contribution object that is passed in which is likely to be the same as the template contribution but might not be - if there were a difference template contribution would be correct
After
template contribution value used
Technical Details
Comments