dev/core#2282 Use the proper content type for ICalendar link #19316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
iCalendar (RFC 5545) is a standard method of transferring calendar information between computer systems and is used to import and synchronize events on various platforms and using the proper content type will Improve the end-user experience.
Before
CiviCRM will use the content type of
text/plain
for ICalendar feed.After
CiviCRM will use the content type of
text/calendar
for ICalendar feed.Technical Details
Because of
CRM_Utils_ICalendar::send
will check for content type oftext/calendar
and send a content disposition header with empty filename, I updated it to check for$filename
instead.Comments
Adds test cover
Issue: https://lab.civicrm.org/dev/core/-/issues/2282