Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2282 Use the proper content type for ICalendar link #19316

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

ahed-compucorp
Copy link
Contributor

Overview

iCalendar (RFC 5545) is a standard method of transferring calendar information between computer systems and is used to import and synchronize events on various platforms and using the proper content type will Improve the end-user experience.

Before

CiviCRM will use the content type of text/plain for ICalendar feed.

After

CiviCRM will use the content type of text/calendar for ICalendar feed.

Technical Details

Because of CRM_Utils_ICalendar::send will check for content type of text/calendar and send a content disposition header with empty filename, I updated it to check for $filename instead.

Comments

Adds test cover

Issue: https://lab.civicrm.org/dev/core/-/issues/2282

@civibot
Copy link

civibot bot commented Jan 4, 2021

(Standard links)

@civibot civibot bot added the master label Jan 4, 2021
@eileenmcnaughton
Copy link
Contributor

Looks good to me. Thanks for including a test

@eileenmcnaughton eileenmcnaughton merged commit a9d978a into civicrm:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants