Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2292 - Add Timeline dropdown on Manage Case not working after buttons UI changes #19356

Merged
merged 1 commit into from
Jan 10, 2021

Conversation

demeritcowboy
Copy link
Contributor

@demeritcowboy demeritcowboy commented Jan 10, 2021

Overview

https://lab.civicrm.org/dev/core/-/issues/2292

The dropdown works by clicking a hidden button when you change the value. The button name no longer submits the same way in $_POST.

Before

Add timeline appears to submit but nothing is added.

After

Works

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jan 10, 2021

(Standard links)

@civibot civibot bot added the master label Jan 10, 2021
@demeritcowboy demeritcowboy changed the title dev/core#2292 - Add Timeline dropdown not working after buttons UI changes dev/core#2292 - Add Timeline dropdown on Manage Case not working after buttons UI changes Jan 10, 2021
@demeritcowboy demeritcowboy force-pushed the add-timeline-buttons-fix branch from fc77c29 to 221e720 Compare January 10, 2021 20:36
@seamuslee001
Copy link
Contributor

I did an R-run of this and confirmed it works, Merge on pass

@seamuslee001 seamuslee001 merged commit 771a26f into civicrm:master Jan 10, 2021
@demeritcowboy demeritcowboy deleted the add-timeline-buttons-fix branch January 10, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants