Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Fix issue where by mailing urls were always stuck in the origin… #20102

Merged
merged 1 commit into from
May 26, 2021

Conversation

seamuslee001
Copy link
Contributor

…al language not the overriden language in a multilingual site

Overview

This fixes an issue where by if you are running a multilingual Drupal 8 site with inherit language enabled the mailing urls in a test mailing remain the original language not the language set in the mailing

Before

  1. Create a Drupal 8 Site, set it to be multilingual french and English and make sure Drupal is also multilingual, make sure the french url adds /fr onto the end of the base url.
  2. Create a new mailing on the English site but set the language of the mailing to be French
  3. Send a test email, find that the unsubscribe etc urls go to the site without /fr enabled even tho the mailing is in French

After

Find that the urls are correct.

ping @MikeyMJCO @mlutfy @KarinG

…al language not the overriden language in a multilingual site
@civibot
Copy link

civibot bot commented Apr 19, 2021

(Standard links)

@civibot civibot bot added the master label Apr 19, 2021
@KarinG
Copy link
Contributor

KarinG commented Apr 19, 2021

Thanks @seamuslee001 - working with a client to reproduce & test.

@seamuslee001
Copy link
Contributor Author

@KarinG how did you go? @mlutfy just wondering if you have had any capacity to review this (understandable if you haven't)

@mlutfy
Copy link
Member

mlutfy commented May 14, 2021

@samuelsov might be interested?

@samuelsov
Copy link
Contributor

Wow, getCurrentLanguage is in fact getDefaultLanguage, obvious isn't it :)

@seamuslee001 I can confirm the bug and that it's fixed by the PR. Thanks!

Ready for merge.

@eileenmcnaughton
Copy link
Contributor

Thanks @samuelsov !

@eileenmcnaughton eileenmcnaughton merged commit 8be074b into civicrm:master May 26, 2021
@seamuslee001 seamuslee001 deleted the d8_mailing_urls branch May 26, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants