Remove defunct default return property

[eileenmcnaughton]

Overview

Remove defunct default return property

Before

I was unable to get anything returned in this field - I think it predates websites having
their own table & is unused. Note that the BAO_MessageTemplateTest classs
shows 'url' being populated in tokens but this not being populated

After

No-one else should have to think about this ever again

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@colemanw @demeritcowboy do one of you want to check my logic on this - I think it was an actual field once....

[demeritcowboy]

I had started to look at this and got sidetracked. I can take a look.

[eileenmcnaughton]

thanks @demeritcowboy - I tested by creating a contact with various websites attached & then doing a contact_get & confirming it stayed empty

[demeritcowboy]

Going to agree. See

https://github.com/civicrm/civicrm-svn/blob/46df80d543362780c1661eb51aa32503e5ec53e5/CRM/Upgrade/Incremental/sql/3.2.alpha1.mysql.tpl#L162-L166

and

1f7272b#diff-2a5e54db718161839151b9467f0a591dae17fe36d362b19a238a3d2c31f0e7b1

[eileenmcnaughton]

Oh wow! you found it!