[Test] Add test cover for contribution tokens in pdf letter #20217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
contop
branch
6 times, most recently
from
342af15 to
a37f63a
Compare
|
@eileenmcnaughton test fails look related |
eileenmcnaughton
force-pushed
the
contop
branch
2 times, most recently
from
30658b8 to
9624b38
Compare
eileenmcnaughton
force-pushed
the
contop
branch
2 times, most recently
from
d31575a to
d92bdff
Compare
…loser to default test db state
|
@seamuslee001 I fought the tests & I won! The actionScheduleTest was too clever by half & much too dumb. It 'required' the domain contacts to be deleted prior to running and was stealing & deleting membership types, statuses & event types. It's much closer to a 12 year old & much less like a teenager now |
|
Test only changes look good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[Test] Add test cover for contribution tokens in pdf letter
Before
Tests lacking
After
Tests added
Technical Details
Comments
@totten this will help us sync with the token processor for contributions. I note that the fields turn out to map well to db fields so I think we can switch the internals to apiv4 for greater predictability