Activate user when no activation is required #20229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
homotechsual
suggested changes
May 5, 2021
CRM/Utils/System/Drupal8.php
Outdated
| @@ -49,7 +49,7 @@ public function createUser(&$params, $mail) { | |||
| if ($user_register_conf != 'visitors' && !$user->hasPermission('administer users')) { | |||
| $account->block(); | |||
| } | |||
| elseif ($verify_mail_conf) { | |||
| elseif { | |||
There was a problem hiding this comment.
Suggested change
| elseif { | |
| else { |
There was a problem hiding this comment.
Pushed, you are really quick. I was about to push the change
|
@pradpnayak @MikeyMJCO can we get a bit more explanation on this PR - it seems to be agreed between you which is fairly compelling to me but the explanation is lacking |
|
@pradpnayak @MikeyMJCO ping |
|
Before - there’s no way to create an active user with email validation enabled in Drupal. After - any user created on a site that doesn’t require admin approval is active. |
|
Thanks I added that into the template & am taking that as your please-merge review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
https://chat.civicrm.org/civicrm/pl/pda9f67bofn17decw35jpztf1h
Before
Before - there’s no way to create an active user with email validation enabled in Drupal.
After
After - any user created on a site that doesn’t require admin approval is active.
Technical Details
Comments