[Test] Improve cleanup of domain contacts #20253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
cont_test
branch
2 times, most recently
from
90d5edc to
9ead775
Compare
|
Looks like there will be some whackamole here ... |
This fixes a situation where the domain contact may not have an email (or exist) if this test is run in combination with certain others. The last test in the suite relies on the domain contact having an email. This test was not following the practice of having a tearDown but the tearDown was also flawed in recreating the domain contacts but not their emails
eileenmcnaughton
force-pushed
the
cont_test
branch
from
9ead775 to
3cf02d6
Compare
|
Test only fixes and UTs have passed merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes a situation where the domain contact may not have an email if the api_v3_ContributionTest
test is run in combination with certain others. The last test in the suite relies on the
domain contact having an email.
Before
class does not follow practice of tearDown calling parent
After
parent::tearDown called. In addition improvements made to createDomainContacts() function to be closer to re-instating them as originally declared
Technical Details
This test was not following the practice
of having a tearDown but the tearDown was also flawed in recreating the domain
contacts but not their emails
Comments